Adopt rubyfmt for code formatting - #18
Merged
Merged
Conversation
Reformats all Ruby files with rubyfmt v0.14.1 and adds a required "Rubyfmt" CI check that runs `rubyfmt --check` against the codebase, mirroring the convention already used in rubyatscale/pack_stats.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Restrict the push trigger to main so pushes to a branch with an open PR only trigger the pull_request run, not both.
Addresses the GitHub Advanced Security finding "actions/missing-workflow-permissions": without an explicit permissions block, jobs inherit the repo/org default GITHUB_TOKEN permissions. Neither job needs more than read access to the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/,spec/,Rakefile,code_manifest.gemspec,Gemfile,bin/console) with rubyfmt v0.14.1RubyfmtCI job that installs the pinned rubyfmt binary and runsrubyfmt --check, mirroring the convention already used inrubyatscale/pack_statsAGENTS.mdmain(previously unprotected) to require theTests: Ruby 3.3,Tests: Ruby 3.4,Tests: Ruby 4.0, andRubyfmtchecks before mergeTest plan
bundle exec rspecpasses locally (19 examples, 0 failures) after reformattingrubyfmt --checkpasses locally against all formatted pathsRubyfmtjob passes on this PR