You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Normalize event location countries (locations.country) to the country dropdown #2832
locations.country is the one remaining typed-in country column. It's left out of that cleanup for now.
Ahoy's ahoy_visits.country is filled automatically from visitors' IP addresses and is out of scope.
What's needed
Decide whether Location is still used. The model is marked # TODO remove this class if unused, and nothing in the app creates rows; events pick one in EventsController (@locations).
If it stays: translate locations.country (and state) through AddressTranslation#country / #state — e.g. a locations pass in AddressServices::TranslateExisting, logged the same way.
If the registrations importer work touches event locations, route any country/state it writes through AddressTranslation so nothing off-dropdown lands.
translate_address_answers translates the mailing/organization state and country answers.
contact_type reads address and phone types the same way.
An unrecognized country is left blank. The preview lists what the dropdowns don't offer, and the completion notice counts it (Result#untranslated_addresses).
🤖 From Claude: Checked prod: locations has 2 rows (Hawthorne, California / Darmout, MA — both USA), and 0 events point at either. The Location model looks safe to remove (with events.location_id and the event-form picker) rather than translate; if it stays, it's just two USA → United States rows.
Activity
maebeale commentedon Oct 24, 2026
🤖 From Claude: Checked prod:
locationshas 2 rows (Hawthorne, California / Darmout, MA — bothUSA), and 0 events point at either. TheLocationmodel looks safe to remove (withevents.location_idand the event-form picker) rather than translate; if it stays, it's just twoUSA→United Statesrows.maebeale commentedon Oct 24, 2026
@jmilljr24 i think we can ignore these bc here is the data:
country
locations_total
events_total
USA 2 0
2 rows
id
city
state
country
1 Hawthorne California USA
2 Darmout MA USA