Repository navigation
Associate standalone survey submissions with their event so training feedback automatically tracks on the registrants roster (#2749) - #2768
Open
1steve78 wants to merge 1 commit into
Conversation
1steve78
marked this pull request as ready for review
October 21, 2026 07:30
maebeale
reviewed
Oct 22, 2026
| area: registration | ||
| display_status: admin_facing | ||
| released_on: 2026-10-21 | ||
| pr_number: 2749 |
Collaborator
There was a problem hiding this comment.
this should be 2768, right?
maebeale
reviewed
Oct 22, 2026
Collaborator
There was a problem hiding this comment.
this comment should be updated or removed now?
Contributor
Author
|
Thanks for the review! I'll correct the |
…feedback automatically tracks on the registrants roster (rubyforgood#2749)
1steve78
force-pushed
the
pass-event-id-to-survey
branch
from
October 25, 2026 12:53
b25d651 to
3603ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 event ID param handling and survey completion association
Allows staff to share standalone survey links with an event attached so respondent answers automatically associate with the training and count toward its survey completion columns.
Closes #2749
What is the goal of this PR and why is this important?
/f/:slug) outside ticket callouts, leaving those completions unassociated./f/:slug?event=42) lets standalone submissions count toward the correct event without heuristic date matching.How did you approach the change?
_form_actions_menu.html.erb) and updated the form editor's "Live at" link to include?event=<id>when an event is present.EventSurveyCompletions.survey_allowed_for_event?to ensure only survey-role forms and events that offer or deliver that survey can be associated.@eventthroughPublicFormsControllertoPublicFormSubmission, persistingevent_idand stamping scholarship survey readiness.?event=<id>across form submissions, error re-renders, and the thank-you return link.EventSurveyCompletionscounts event-associated standalone submissions while ignoring other events and event-less submissions.Anything else to add?