Repository navigation
Conversation
maebeale
changed the title
maebeale
marked this pull request as ready for review
October 25, 2026 10:05
maebeale
force-pushed
the
maebeale/keep-form-answers-verbatim
branch
from
October 25, 2026 12:07
2119eda to
8acfc82
Compare
…resses Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
An answer is a record of what someone submitted, and the dashboards count addresses, not answers. The one real risk of untranslated answers is link-organization and capture re-reading an old "USA" into an address, so those two write points translate instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Country answers that translate to a dropdown country were rewritten once by hand and logged, so the verbatim rule names its one exception and where the trail lives. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
UpsertAddress stores "Texas"/"USA" as TX/United States, but the answers stay as typed, so link-organization's ProfileDiff reported the address it had just saved as a difference. Comparing the answer through AddressTranslation lets them match. Also clarifies in ADR-0009 how the 2026-10-25 hand pass logged address fills differently from a data:translate_addresses run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/keep-form-answers-verbatim
branch
from
October 25, 2026 12:44
8acfc82 to
01ae747
Compare
The prod cleanup was done by hand on addresses in the portal, superseding the console script that would have rewritten country answers, so the docs no longer claim it did. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
They hadn't become addresses yet, so fixing them was the only way to keep their values off the dropdown-backed address they'll turn into when an organization is linked. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The 2026-10-24/25 cleanup corrected addresses in the portal and fixed the few answers that could still become addresses, so the one-time rewrite task and the translation at the answer-to-address write points have nothing left to do. AddressTranslation stays for the FileMaker and registration imports. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
changed the title
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 deletes the one-time translation task + reverts three answer→address write points to main
Prod addresses were cleaned by hand on 2026-10-24/25, so the one-time address translation task is no longer needed; form answers now stay exactly as people typed them.
AddressServices::TranslateExistinganddata:translate_addresses(plus specs).AddressTranslationandFmAddressAttributes.UpsertAddress,CaptureFromSubmission,ProfileDiffare unchanged from main.FormAnswerheader, which mentionTranslateExisting; expect a small doc conflict on rebase.🤖 Generated with Claude Code