[maebeale]

🤖 suggested review level: 3 Read 📖 small view/decorator logic shared by person and org address forms, plus a nested-attributes reject rule

Canadian addresses saved as "CA" (Canada) showed up as California with no way to enter a province — non-USA addresses now get a State text box, and new addresses start from the saved one.

What is the goal of this PR and why is this important?

• State dropdown is US-only, so international addresses couldn't hold a correct value.
• People adding a second address had to re-pick country, state, and locality.

How did you approach the change?

• State text box when the address (or its default country) is outside the USA.
  • Admins get the dropdown by default; ?admin=true gives them the text box on any address (AddressPolicy#enter_any_state?).
• New address defaults copy the saved address: country, state, locality.
  • An active address wins over a retired one, then the most recently updated. The primary flag is pre-checked on every address added, so it can't pick the current one.
  • No saved address → country from the Settings return address (Setting.default_address_country), else United States.
• Blank locality → whatever AddressLocality settles from the address (Outside USA, Outside CA, LA City, LA County, Orange County), blank when it can't guess.
• Country stays optional; the hint still offers blank.
• Logic on AddressDecorator; one shared addresses/_state_field partial; no JS.

An empty address block has to stay droppable

• Pre-filling made an untouched "Add address" block look filled to reject_if, so the block was built and the parent save died on "Addresses city can't be blank".
• reject_if now checks only city, street_address, zip_code (Address.unfilled_attributes?) — the fields someone types. Person and Organization shared one copy of the old proc.
• Address::DEFAULT_COUNTRY is now the only place "United States" is written; GeographyHelper and AddressTranslation point at it. A spelling that drifts from the option string renders the select blank.

Features seed (optional)

• Added a features seed (optional)

UI Testing Checklist

• Person edit, US address → state dropdown
• Person edit, Canada address → state text box
• Person with a saved address → Add address copies its country, state, locality
• Person whose only live address is retired → Add address skips it for the active one
• Person with no addresses → Add address starts in the return address's country
• Admin with ?admin=true → text box on a US address
• Org edit, non-USA address → text box
• Org edit → Add Address, fill in nothing, Save → saves clean, no new address

Anything else to add?

• Changing the country doesn't swap the state field until the address is saved and reopened; admins can use ?admin=true in the meantime.

🤖 Generated with Claude Code