Repository navigation
Conversation
maebeale
marked this pull request as ready for review
October 25, 2026 13:46
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A registrant licensed in Ontario had no way to say so: every state field was a US-only dropdown, and a saved non-US value rendered blank so the next save wiped it. An "Outside USA?" <details> box beside each dropdown takes a typed state and wins when filled, so nothing a person already entered is lost. Licenses also record an issuing country, since a province alone doesn't place a license. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Outside the USA a province is the likelier answer, so name it first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
No dev seed delivered a form on a ticket callout: the Feedback surveys callout links its survey forms only when created, and no survey form existed yet. A short post-event survey with a state question now opens on it, so callout forms and the Outside USA box can be tried from any flagship ticket. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…try at registration A province alone doesn't place a license or an answer, so a <prefix>_country question now rides inside its <prefix>_state question's Outside USA box, and the CE section asks which country issued the license. A US registrant never opens the box, so a blank paired country beside a US state records the US. The Smart field settings page now explains what the _state and _country endings do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Admins looking for licenses from a region had to scan the whole list. A Location box now matches where a license was issued and where its holder lives, taking a US state by name or code, a province, a country, or the start of a city. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…v survey A license picked from the US-state dropdown named no country, unlike a form answer beside a US state, which records the US — so licenses now default the same way. Dev databases that already held a post-event survey never got its location questions or an open callout to try them on; the seed now adds both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
grid_span_class is read by the answer-display pages as well as the form pages, so hiding the paired country field there dropped its recorded answer from the registration confirmation page — including the United States now filled in automatically. Skip the field where the form is asked instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/professional-license-state-form
branch
from
October 25, 2026 14:19
b68bcf8 to
3e323a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 5 Inspect 🔬 migration + param handling across 7 forms (public, registrant, admin)
Registrants licensed outside the USA couldn't enter their state or province — every state field was a US-only dropdown, and a saved non-US value rendered blank so the next save wiped it.
<details>link under each state dropdown; opens a Province / State box. No JS, no page reload, nothing else on the form lost.issuing_country(new nullable column, no backfill). Shown as "Ontario, Canada"._statequestion on public/registration/callout forms.required— someone abroad leaves the dropdown blank. Server-side required validation still runs on the merged answer.ce_license_picker(existing controller) now fills the box + country when switching licenses.<prefix>_countryquestion now sits inside its<prefix>_statequestion's box.DRY_RUN) is in the session notes.🤖 Generated with Claude Code