fix(WeeklyTrifles):修复每周琐事摸鱼行动问题

[Hurry2]

-上周存储弹窗挡住全部存储标志直接退出的情况

• 同时删除sleep，使用interval参数代替

Summary by Sourcery

修复每周摸鱼保存流程，确保弹窗遮挡时仍能正确完成保存操作。

Bug Fixes:

• 修复每周摸鱼保存流程中存储弹窗遮挡保存标志导致流程提前退出的问题。

Enhancements:

• 用交互操作的 interval 参数替代固定等待，提升每周摸鱼保存流程的稳定性。

Original summary in English

Summary by Sourcery

修复每周摸鱼保存流程，确保弹窗遮挡时仍能正确完成保存操作。

Bug Fixes:

• 修复每周摸鱼保存流程中存储弹窗遮挡保存标志导致流程提前退出的问题。

Enhancements:

• 用交互操作的 interval 参数替代固定等待，提升每周摸鱼保存流程的稳定性。

[sourcery-ai]

你好 - 我发现了 1 个问题

给 AI 代理的提示

请处理此次代码审查中的评论：

## 单条评论

### 评论 1
<location path="tasks/WeeklyTrifles/script_task.py" line_range="103" />
<code_context>
-                    )
-                    continue
-                if self.appear_then_click(self.I_WT_HAPPY_GET):
+                if self.appear_then_click(self.I_WT_HAPPY_GET, interval=1):
                     continue
                 if cu_tickts >= cost_tickts and not_save_flag:
</code_context>
<issue_to_address>
**上周弹窗导致跳过保存**

上次保存指示器消失后，如果上周弹窗仍然显示并遮挡了“全部保存”控件，`ui_click_until_smt_disappear` 可能会在上周弹窗仍覆盖“全部保存”控件时结束。随后，初始的 `appear(I_WT_SAVE_ALL)` 检查会跳过包含此 `I_WT_HAPPY_GET` 点击的循环，任务便会返回主页面而没有保存。

请在检查 `I_WT_SAVE_ALL` 之前关闭 `I_WT_HAPPY_GET`，然后刷新屏幕并继续保存流程。
</issue_to_address>

Sourcery 评估

等待批准。 请先处理 1 个问题。

阻塞性问题：tasks/WeeklyTrifles/script_task.py:103

---

Sourcery 对开源项目免费——如果您喜欢我们的审查，欢迎分享 ✨

• X
• Mastodon
• LinkedIn
• Facebook

Original comment in English

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="tasks/WeeklyTrifles/script_task.py" line_range="103" />
<code_context>
-                    )
-                    continue
-                if self.appear_then_click(self.I_WT_HAPPY_GET):
+                if self.appear_then_click(self.I_WT_HAPPY_GET, interval=1):
                     continue
                 if cu_tickts >= cost_tickts and not_save_flag:
</code_context>
<issue_to_address>
**Prior-week popup skips saving**

When the prior-week popup remains visible after the last-save indicator disappears and obscures the save-all control, `ui_click_until_smt_disappear` can finish while the prior-week popup still covers the save-all control. The initial `appear(I_WT_SAVE_ALL)` check then skips the loop containing this `I_WT_HAPPY_GET` click, and the task returns to the main page without saving.

Dismiss `I_WT_HAPPY_GET` before checking `I_WT_SAVE_ALL`, then refresh the screen and continue the save flow.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: tasks/WeeklyTrifles/script_task.py:103

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[github-actions]

Findings

• C2 [风险]
  位置:tasks/WeeklyTrifles/script_task.py:ScriptTask._save_touch_fish,进入保存页面后的等待逻辑(约第 87 行)
  原因:清单禁止任务流程使用 sleep,当前新增 sleep(0.5);同时折叠窗口 while 1 仅依赖页面出现,缺少超时或失败退出条件。
  修改:移除固定 sleep,改用已有交互等待/稳定性机制,并为入口循环增加超时或明确失败退出处理。

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by PR Review Checklist for #1943 · codex · gpt56 · 16.4 AIC · ⌖ 2.8 AIC · ⊞ 12.1K · ◷