Repository navigation
feat: run the bindings tool through rc, add rc doctor, forward termination, and test on Windows - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rc bindings <command>runsrc-bindings(orRC_BINDINGS_BIN) and passes every argument through, sorcdoes not need the unpublished extensions Go modules. The tool is added in runtimeconditions/extensions ascmd/rc-bindings.rc doctorlists the bindings tool and each profiler with version and core schemas, and fails when one is incompatible..cmdshims.rc-profiler-go.rbfrom the latest Go profiler release, andrc.rbdepends on it.The workflow additions that only run on GitHub (Windows job, Go profiler formula step) are untested locally.