Skip to content

feat: run the bindings tool through rc, add rc doctor, forward termination, and test on Windows - #2

Merged
magic-peach merged 2 commits into
mainfrom
bindings-doctor-signals
Oct 28, 2026
Merged

magic-peach merged 2 commits into
mainfrom
bindings-doctor-signals

Conversation

@magic-peach

Copy link
Copy Markdown
Member
  • rc bindings <command> runs rc-bindings (or RC_BINDINGS_BIN) and passes every argument through, so rc does not need the unpublished extensions Go modules. The tool is added in runtimeconditions/extensions as cmd/rc-bindings.
  • rc doctor lists the bindings tool and each profiler with version and core schemas, and fails when one is incompatible.
  • Plugins run through one helper that forwards SIGTERM, leaves Ctrl-C to the terminal, passes stdin through, and returns the exit status. Real-binary tests cover stdin, exit status and SIGTERM.
  • CI adds Windows, with a test for npm-style .cmd shims.
  • The Go profiler stays a separate executable. The release also generates rc-profiler-go.rb from the latest Go profiler release, and rc.rb depends on it.

The workflow additions that only run on GitHub (Windows job, Go profiler formula step) are untested locally.

@magic-peach
magic-peach merged commit 43a3a09 into main Oct 28, 2026
5 checks passed
@magic-peach
magic-peach deleted the bindings-doctor-signals branch October 28, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant