Skip to content

Overly aggressive escaping in 2.0 breaking multi-level breadcrumbs #32

Description

@FPCSJames

In 2.0, most instances of $delimiter and other static variables in flexia_breadcrumbs() are wrapped in esc_attr(). This is causing breadcrumbs to be output as text containing < and > instead of valid tags.

There is no need to escape these variables. There is no way for the administrator or a developer to modify their contents (a filter, a Customizer option, etc.). All the addition of these escapes does is break the code, not solve any problem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions