Conversation
Updating an existing site replaced its header and footer, because both patterns were rewritten under their existing slugs while the template parts only reference those slugs. Saved parts that contain nothing but a wp:pattern reference re-resolve to the new markup, so preserving the database record did not preserve the layout. Restore patterns/header.php and patterns/footer.php to their 3.1.0 markup, and ship the native-identity chrome as the new header-minimal and footer-minimal patterns. Give the minimal header's navigation an explicit page-list fallback so it no longer resolves to an unrelated saved menu, and lay that header out nowrap so WooCommerce's account and mini-cart icons stay on the logo row. Stop underlining button-shaped links inside post content, which also underlined WooCommerce's Proceed to Checkout button, and correct the migration note on database-saved template parts. Covers FX-01 to FX-05 from the 3.2.1 upgrade QA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 3.2.1 upgrade QA, which failed sign-off on four blocking issues.
Cause
parts/header.htmlandparts/footer.htmlcontain nothing but awp:patternslug reference. 3.2.0 rewrotepatterns/header.phpandpatterns/footer.phpunder those same slugs, so every site — customized or not — picked up the new chrome on update. A database-saved template part that only holds a pattern reference re-resolves the same way, so preserving the saved record did not preserve the layout.Changes
patterns/header.phpandpatterns/footer.phprestored byte-identical to 3.1.0. The 3.2.0 chrome ships as the newflexia/header-minimalandflexia/footer-minimalpatterns, selectable in the Site Editor.wp:navigationgets an explicitwp:page-listfallback, so it no longer resolves to the most recently created menu. The restored header carries its own inline links and never hits the fallback.nowrap, keeping WooCommerce's injected account and mini-cart icons on the logo row..wp-block-post-content ano longer underlines.wp-element-button,.wp-block-button__linkor.wc-block-components-button.tools/release-files.txtso the manifest builder ships them.FX-06 needs no change:
patterns/single-product.phpalready carriesInserter: no, so the pattern never reaches the block inserter.Verification
tools/check-theme.py— 832 block declarations, 0 errorsgit diff 7fa2ef7^Still open
FX-04 needs a browser re-test against the restored header, which keeps its original
flexWrap: "wrap". The reported slowdown on 3.2.0 is not addressed here.🤖 Generated with Claude Code