Don't create an intermediate &[u8] when initializing Tlsf alloc - #110
Merged
Conversation
Merged
zeenix
approved these changes
Nov 25, 2025
zeenix
left a comment
zeenix
left a comment
Contributor
There was a problem hiding this comment.
Had to really scratch me head to understand what's going on but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fully fixes #108 - by no longer creating an intermediary
&[u8], this should remove the source of UB, assuming that Tlsf does not require the backing storage to be initialized.