IndexMap: add insert_full and Index<usize> - #686
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
Port the index-oriented accessors from the upstream indexmap crate so an IndexMap can be inserted into and read back by position. insert_full returns the entry index alongside the old value, and Index/IndexMut<usize> allow map[i] lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the index-oriented accessors from the upstream indexmap crate, as suggested in #325.
insert_fullbehaves likeinsertbut also hands back the entry's index, andIndex<usize>/IndexMut<usize>let you read and write values by position withmap[i]. Both round out the existingget_indexfamily so you can refer to entries by position as well as by key.Closes #325