ci: Update which targets build musl - #1278
Merged
Merged
Conversation
tgross35
force-pushed
the
musl-libm-build
branch
from
August 17, 2026 09:56
ac119e9 to
4db1a5b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
force-pushed
the
musl-libm-build
branch
4 times, most recently
from
September 3, 2026 05:10
b7c5945 to
5f9729b
Compare
tgross35
changed the title
tgross35
force-pushed
the
musl-libm-build
branch
from
September 3, 2026 05:11
5f9729b to
bc82866
Compare
tgross35
changed the title
tgross35
enabled auto-merge (rebase)
September 3, 2026 05:13
Provide reasoning for skips, and enable thumb since this seems to work.
Also, change wasm32-unknown-unknown to be a proper build-only target.
The mentioned failures on MinGW are cases like:
thread 'musl_edge_case_expf' (1728) panicked at libm-test\tests\compare_built_musl.rs:26:50:
called `Result::unwrap()` on an `Err` value:
input: (0.0,)
as hex: (+0x0p+0,)
as bits: (0x00000000,)
expected: 0.0 +0x0p+0 0x00000000
actual: 1.0 +0x1.000000p+0 0x3f800000
thread 'musl_edge_case_ceil' (1964) panicked at libm-test\tests\compare_built_musl.rs:26:50:
called `Result::unwrap()` on an `Err` value:
input: (1.0000000000000002,)
as hex: (+0x1.0000000000001p+0,)
as bits: (0x3ff0000000000001,)
expected: 1.0 +0x1.0000000000000p+0 0x3ff0000000000000
actual: 2.0 +0x1.0000000000000p+1 0x4000000000000000
Our libm's results are correct, for some reason musl is off (something
about the fp environment on x86, or a different FLT_EVAL_MODE?)
tgross35
force-pushed
the
musl-libm-build
branch
from
September 3, 2026 05:27
bc82866 to
c1568af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide reasoning for skips, and enable thumb since this seems to work.
Also, change wasm32-unknown-unknown to be a proper build-only target.
ci: test-libm