markdown: Resolve . and .. segments in relative URLs - #14516
Open
jakobjung10 wants to merge 1 commit into
Open
Conversation
Relative URLs were appended to the README's directory verbatim, so a link like `../img/logo.png` in a crate that lives in a subdirectory of its repository produced a `raw/HEAD/subdir/../img/logo.png` URL that GitHub serves a 404 for. Resolve the segments before building the URL, clamping at the repository root. SVGs were unaffected because appending the `sanitize=true` query reparses the URL, which collapses the segments as a side effect. Closes rust-lang#5318
jakobjung10
force-pushed
the
normalize-relative-readme-urls
branch
from
August 25, 2026 14:37
42436af to
09550b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative URLs were appended to the README's directory verbatim, so a link like
../img/logo.pngin a crate that lives in a subdirectory of its repository produced araw/HEAD/subdir/../img/logo.pngURL that GitHub serves a 404 for. Resolve the segments before building the URL, clamping at the repository root.SVGs were unaffected because appending the
sanitize=truequery reparses the URL, which collapses the segments as a side effect.Closes #5318