tests/owners: Improve login resolution coverage - #14550
Merged
Merged
Conversation
Unprefixed owner additions and removals resolve `users.gh_login` case-insensitively, including when the crates.io username differs. Co-authored-by: moskirathe <tech@alphajiri.co>
Turbo87
added
the
C-internal 🔧
moskirathe
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the owner-login tests from #14213 into a standalone change. They record how owner additions and removals currently handle distinct crates.io usernames and legacy GitHub logins, including prefixes, casing, and hyphen/underscore variants. This gives the later disambiguation changes a clear behavioral baseline.
Related
cargo ownerparam handling and error messages #13769