controllers/owners: Parse add-owner arguments before dispatch - #14554
Merged
Conversation
Turbo87
added
the
C-internal 🔧
Turbo87
force-pushed
the
owner-login-parser
branch
from
August 29, 2026 22:09
1363814 to
47f3ee2
Compare
moskirathe
approved these changes
Aug 30, 2026
Co-authored-by: moskirathe <tech@alphajiri.co>
Co-authored-by: moskirathe <tech@alphajiri.co>
Turbo87
force-pushed
the
owner-login-parser
branch
from
August 30, 2026 20:27
47f3ee2 to
a3e5516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts GitHub team parsing into
GitHubTeamLoginand introduces aLoginenum so add-owner dispatch operates on parsed variants instead of raw strings.The refactor preserves the existing unprefixed user and
github:org:teambehavior. It was extracted from #14213 so the parsing foundation can be reviewed independently from owner username disambiguation.Related
cargo ownerparam handling and error messages #13769