Simplify owner handlers for username disambiguation - #14569
Merged
Conversation
The permission check uses the owner list loaded earlier. Another request can change that list before this request changes any owners, even when both steps happen inside the transaction. Moving the check does not introduce that possibility. All changes to owners and the check that at least one individual owner remains still happen in one transaction. If any step fails, all changes are undone. The permission check can also call GitHub. The transaction now starts after those calls finish.
Each handler owns its transaction and response. The ten-entry invitation limit applies only to `add_owners()`.
Turbo87
added
the
C-internal 🔧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding and removing owners follow different workflows, but
modify_owners()combines them behind anaddflag. Splitting them into their endpoint handlers makes each workflow easier to read and lets us change their username resolution independently for #14213. Small helpers keep permission checks and invitation email rendering out of the main flow.Crate loading and permission checks also move before the transaction, so GitHub calls during permission checks no longer keep a transaction open. Ownership changes and the check that at least one individual owner remains stay in one transaction. The ten-entry limit now applies only to additions.
Related