Use crates.io username in admin contexts - #14576
Merged
Turbo87 merged 1 commit intoSep 2, 2026
Merged
Conversation
As part of the transition to crates.io usernames, change admin commands and APIs to use `users.username` rather than `users.gh_login`. End users of crates.io should not see any observable effects of this PR. Admins will need to remember that: - Looking up a user by their token with the `verify-token` command will return the user's crates.io username, which currently always matches their GitHub username, but that will not necessarily be the case in the future. - Using the `list_admin` API will look up users by their crates.io username (I think I might be the only one who uses this) - Usernames in some log messages will now be crates.io usernames (I added "crates.io username" to the log messages as a clarification)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the transition to crates.io usernames, change admin commands and APIs to use
users.usernamerather thanusers.gh_login.End users of crates.io should not see any observable effects of this PR.
Admins will need to remember that:
verify-tokencommand will return the user's crates.io username, which currently always matches their GitHub username, but that will not necessarily be the case in the future.list_adminAPI will look up users by their crates.io username (I think I might be the only one who uses this)Extracted from #14575. Shouldn't conflict with #14213.