In tests, where appropriate, use users.username - #14577
Merged
Merged
Conversation
Instead of `users.gh_login`. For now, these fields should always be the same, so there is no change in the test or implementation behavior. When we fully enable crates.io usernames as being independent of GitHub usernames, these tests should be using the crates.io username.
Turbo87
approved these changes
Sep 3, 2026
Turbo87
added
the
C-internal 🔧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
users.gh_login.For now, these fields should always be the same, so there is no change in the test or implementation behavior coverage.
When we fully enable crates.io usernames as being independent of GitHub usernames, these tests should be using the crates.io username.
Extracted from #14575. Might conflict with #14213 a tiny bit.