controllers/owners: split owner remove query to remove by username and remove by team name - #14596
Open
moskirathe wants to merge 5 commits into
Open
controllers/owners: split owner remove query to remove by username and remove by team name#14596moskirathe wants to merge 5 commits into
moskirathe wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a partial extraction from #14213.
It splits the
owner_removequery toowner_remove_by_usernameandowner_remove_by_team_name. This will allow us to change the behaviour ofower_remove_by_usernameso that we can compare usernames names using the canon_username function (which also normalizes hyphen to underscore), but keep comparing team names usinglower- github allows separate team names that only differ by underscore and hyphens to exist.Tests:
Owner remove is now routed through
Login:parse, which rejects malformed logins before any DB lookup happens.Login::parsecurrently treats any login containing:as a team login and hands it toGitHubTeamLogin::parse, which rejects malformed ones with abad_request.Previously
remove_ownerspassed the raw string straight tokrate.owner_remove, which did the lookup, matched nothing (stored logins never contain:), and returnedOwnerRemoveError::not_found(login).So the tests, which assert the old fall-through behavior, now get a parse error instead.