Remove rustc-workspace-hack - #2916
Merged
Merged
Conversation
Member
|
This sounds like a PR that would be better to land in rustc first, not in the subrepo? That's where it will lead to build errors if things go wrong, after all. |
ehuss
force-pushed
the
remove-workspace-hack
branch
from
June 4, 2023 16:17
c998cc2 to
54b5e33
Compare
Contributor
Author
|
I can do it there if you want, but I don't suspect there will be any issues. |
Member
|
Ah, fair. cargo-miri/Cargo.lock will probably also need updating. |
Contributor
Author
|
The lock should be updated now. |
ehuss
force-pushed
the
remove-workspace-hack
branch
from
June 4, 2023 16:22
54b5e33 to
f089f76
Compare
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rustc-workspace-hackdependency was removed in rust-lang/rust#109133 and should no longer be needed.