Regenerate test expectations for libclang 23.0.0. - #3430
Open
flowerhack wants to merge 1 commit into
Open
Conversation
When using bindgen with the newest clang version, `bindgen-tests` currently fail. I believe these are linked to a couple changes in Clang, e.g. * llvm/llvm-project#198452, which changes how doc comments are extracted * llvm/llvm-project#147835, which changes how dependent types names are parsed, and thus e.g. what *was* a BindgenOpaqueArray is now omitted (because bindgen can more easily parse the new format) This commit regenerates test expectations so they pass with the newer clang. (We observed this in Chromium because Chromium rolls Clang roughtly every 1-2 weeks; this corresponds with 23.0.0.)
Author
|
r? @emilio I'm new here, but believe I followed all guidelines in CONTRIBUTING.md; lmk if I missed anything. I didn't see any kind of LLM policy, but, in case there's one and I missed it: I used Gemini to diagnose the probable root cause for the test failure. I reviewed the LLM's reasoning to confirm its veracity. Then, I ran the commands for regenerating expectations files myself & updated the associated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using bindgen with the newest clang version,
bindgen-testscurrently fail.I believe these are linked to a couple changes in Clang, e.g.
This commit regenerates test expectations so they pass with the newer clang.
(We observed this in Chromium because Chromium rolls Clang roughtly every 1-2 weeks; this corresponds with 23.0.0.)
(These are new additions to a new
libclang-22directory rather than updates to the current versions of these files, since these changes were introduced post-libclang-v22.)