Skip to content

Regenerate test expectations for libclang 23.0.0. - #3430

Open
flowerhack wants to merge 1 commit into
rust-lang:mainfrom
flowerhack:i-did-it
Open

Regenerate test expectations for libclang 23.0.0.#3430
flowerhack wants to merge 1 commit into
rust-lang:mainfrom
flowerhack:i-did-it

Conversation

@flowerhack

@flowerhack flowerhack commented Aug 12, 2026

Copy link
Copy Markdown

When using bindgen with the newest clang version, bindgen-tests currently fail.

I believe these are linked to a couple changes in Clang, e.g.

This commit regenerates test expectations so they pass with the newer clang.

(We observed this in Chromium because Chromium rolls Clang roughtly every 1-2 weeks; this corresponds with 23.0.0.)

(These are new additions to a newlibclang-22 directory rather than updates to the current versions of these files, since these changes were introduced post-libclang-v22.)

When using bindgen with the newest clang version, `bindgen-tests` currently fail.

I believe these are linked to a couple changes in Clang, e.g.
*  llvm/llvm-project#198452, which changes how
   doc comments are extracted
* llvm/llvm-project#147835, which changes how
  dependent types names are parsed, and thus e.g. what *was* a
  BindgenOpaqueArray is now omitted (because bindgen can more easily parse
  the new format)

This commit regenerates test expectations so they pass with the newer
clang.

(We observed this in Chromium because Chromium rolls Clang roughtly
every 1-2 weeks; this corresponds with 23.0.0.)
@flowerhack

Copy link
Copy Markdown
Author

r? @emilio

I'm new here, but believe I followed all guidelines in CONTRIBUTING.md; lmk if I missed anything.

I didn't see any kind of LLM policy, but, in case there's one and I missed it: I used Gemini to diagnose the probable root cause for the test failure.

I reviewed the LLM's reasoning to confirm its veracity.

Then, I ran the commands for regenerating expectations files myself & updated the associated .toml/.rs files accordingly & ran the appropriate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants