Update workspace dependencies - #3433
Open
tagawa0525 wants to merge 2 commits into
Open
Conversation
Pin all workspace dependencies to their latest versions, notably: - annotate-snippets 0.11 -> 0.12: port diagnostics.rs to the new Group/Element API (Level enum variants became consts with a lifetime parameter, Snippet::origin() became path(), title/footer composition now goes through Group). Snippets set fold(false) to keep showing unannotated source lines as before. - libloading 0.8 -> 0.9: no code changes needed; the dyngen template already passes &OsStr to Library::new (5813198), which satisfies libloading 0.9's AsFilename bound. The generated dynamic_loading_* expectations compile against 0.9 unchanged. - env_logger 0.10 -> 0.11, similar 2 -> 3: no code changes needed. cargo test results are unchanged from before this commit: the two failing expectation tests (issue-544-stylo-creduce-2, nsbasehashtable) also fail on the unmodified tree with libclang 21 and are unrelated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TwjQ7wD6uxpJMX6jzPRj9K
- diagnostics.rs: annotate-snippets 0.12's render() returns String directly, so the to_string() call became an implicit clone (clippy::implicit_clone); iterate over the String's lines directly. - quickchecking: quickcheck 1.1 deprecated QuickCheck::gen in favor of QuickCheck::rng. - regex_set.rs: add missing backticks in a doc comment (clippy::doc_markdown). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TwjQ7wD6uxpJMX6jzPRj9K
There was a problem hiding this comment.
Pull request overview
Updates the workspace’s pinned dependency versions and adjusts bindgen’s code to accommodate upstream API changes (notably annotate-snippets and quickcheck), keeping diagnostic output and tests functioning under the new dependency set.
Changes:
- Bump and re-pin
[workspace.dependencies]to newer crate versions and refreshCargo.lockaccordingly. - Port the diagnostics rendering pipeline to
annotate-snippets0.12’sGroup/SnippetAPI and updateLevelusages to the new const-based API. - Update the quickcheck-based test harness to use
QuickCheck::rng(replacing deprecatedQuickCheck::gen).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates workspace dependency pins to newer versions. |
| Cargo.lock | Refreshes the resolved dependency graph/checksums after version bumps. |
| bindgen/regex_set.rs | Updates doc comment formatting and Level::* usages for diagnostics. |
| bindgen/lib.rs | Updates diagnostic emission to use the new Level::* consts. |
| bindgen/ir/var.rs | Updates diagnostic Level usage to the new API. |
| bindgen/ir/context.rs | Updates diagnostic Level usage to the new API. |
| bindgen/diagnostics.rs | Ports diagnostics rendering to annotate-snippets 0.12 Group/Snippet API. |
| bindgen/codegen/mod.rs | Updates diagnostic Level usage to the new API. |
| bindgen-tests/tests/quickchecking/src/lib.rs | Switches from deprecated QuickCheck::gen to QuickCheck::rng. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin all workspace dependencies to their latest versions and adapt the code where APIs changed.
Changes
diagnostics.rsto the newGroup/ElementAPI.Levelenum variants became consts with a lifetime parameter,Snippet::origin()becamepath(), and title/footer composition now goes throughGroup. Snippets setfold(false)to keep showing unannotated source lines as before. Verified the rendered output of--experimental --emit-diagnostics(invalid-regex warning) still displays correctly.&OsStrtoLibrary::new(5813198 / feat(dyngen): preconvert path toOsStrwhen opening the library #3315), which satisfies libloading 0.9'sAsFilenamebound. The generateddynamic_loading_*expectations compile against 0.9 unchanged.QuickCheck::genis deprecated (genis a Rust 2024 keyword) → useQuickCheck::rng.implicit_clonein diagnostics.rs,doc_markdownin regex_set.rs).Test
cargo testresults are unchanged from the unmodified tree: the two expectation tests failing locally (issue-544-stylo-creduce-2, nsbasehashtable) also fail on clean main with libclang 21 and are unrelated to this change.