Skip to content

Move driver tests to an actual test - #17576

Open
Jarcho wants to merge 1 commit into
rust-lang:masterfrom
Jarcho:driver-test
Open

Move driver tests to an actual test#17576
Jarcho wants to merge 1 commit into
rust-lang:masterfrom
Jarcho:driver-test

Conversation

@Jarcho

@Jarcho Jarcho commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

cc @flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 17, 2026
CommanderStorm
CommanderStorm approved these changes Aug 17, 2026
View reviewed changes

@CommanderStorm CommanderStorm left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community review

View changes since this review

Jarcho
Jarcho commented Aug 27, 2026
View reviewed changes
Comment thread .github/driver.sh
Comment on lines -50 to -52
./target/debug/clippy-driver -Dwarnings -Aunused -Zui-testing --emit metadata --crate-type bin tests/ui/char_lit_as_u8.rs 2>char_lit_as_u8.stderr && exit 1
sed -e "/= help: for/d" char_lit_as_u8.stderr > normalized.stderr
diff -u normalized.stderr tests/ui/char_lit_as_u8.stderr

@Jarcho Jarcho Aug 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't copied over, but I don't really know what this is testing. compile-test already calls the driver directly and it already succeeded.

View changes since the review

Comment thread .github/driver.sh
Comment on lines -60 to -62
CLIPPY=$(./target/debug/clippy-driver ./target/driver_test.rs --rustc)
RUSTC=$(rustc ./target/driver_test.rs)
diff -u <($CLIPPY) <($RUSTC)

@Jarcho Jarcho Aug 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here. This is only testing that both commands have no output, but clippy-driver without --rustc would also output nothing.

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CommanderStorm CommanderStorm CommanderStorm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jarcho @rustbot @CommanderStorm