feat(unnecessary_self_imports): lint nested imports

[ada4a]

Resolves #17652

changelog: [unnecessary_self_imports]: lint nested imports

[rustbot]

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

[mathstuf]

LGTM overall. Perhaps add a test importing ::{self, Item} to check the span reports the removal of the {, } bits as well? Same with ::{self, Item, OtherItem} not removing the braces, but removing the , .

View changes since this review

[mathstuf]

Ah, this doesn't care about use of self, so my suggested test additions are not relevant to this lint as ::{self, Anything} is not necessarily an unnecessary use (and therefore subject to "unused import" lints).

View changes since this review

[ada4a]

as ::{self, Anything} is not necessarily an unnecessary use (and therefore subject to "unused import" lints).

Exactly right. Thank you for the review:)

[CommanderStorm]

Community review: LGTM, no suggestions.

View changes since this review

[rustbot]

r? @dswij

rustbot has assigned @dswij for the project review.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 9 candidates
• 9 candidates expanded to 9 candidates
• Random selection from Jarcho, Manishearth, blyxyas, dswij, llogiq