Rollup of 9 pull requests - #153044
Closed
JonathanBrouwer wants to merge 24 commits into
Closed
Conversation
This removes `Suppressed` as a must use cause that could be nested in another (we did not ever return this, but now it's encoded in the types). I also renamed Suppressed->Trvial and added some docs to clear confusion.
…nd `ControlFlow<Uninhabited, T>`
`rustc_queries!` produces two macros: `rustc_with_all_queries` and `rustc_feedable_queries`. The latter is similar to the former but only includes feedable queries. But feedable queries don't need a separate mechanism because we can identify feedable queries within `define_callbacks!` by just looking for the `feedable` modifier. (That's what we do with every modifier other than `feedable`.) This commit removes the special handling and treats feedable queries like everything else. Note that this commit exposes and fixes a latent doc bug. The doc comment for query `explicit_predicates_of` links to `Self::predicates_of`. `explicit_predicates_of` is a feedable query but `predicates_of` is not, so for `TyCtxtFeed` this link is invalid. This wasn't manifesting because `TyCtxtFeed` wasn't getting doc comments attached. It now is, so I changed the link to `TyCtxt::predicates_of`.
For the attribute `FooBar` the parser is generally called `FooBarParser` and the kind is called `AttributeKind::FooBar`. This commit renames some cases that don't match that pattern. The most common cases: - Adding `Rustc` to the front of the parser name for a `rustc_*` attribute. - Adding `Parser` to the end of a parser name. - Slight word variations, e.g. `Deprecation` instead of `Deprecated`, `Pointer` instead of `Ptr`, `Stability` instead of `Stable`.
Co-authored-by: Jana Dönszelmann <jana@donsz.nl>
Co-authored-by: Jana Dönszelmann <jana@donsz.nl>
…=Mark-Simulacrum Neon fast path for str::contains Using the SIMD friendly version of the function also gives a decent speed up with Neon.
std: move `exit` out of PAL This PR moves `exit` out of `sys::pal` (as per rust-lang#117276) and into a common module with `unique_thread_exit`.
Streamline `QueryVTableUnerased` into `GetQueryVTable` *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152841)* `QueryDispatcherUnerased` is an awkward name for an awkward trait. We can make it a bit more straightforward by removing its responsibility for erasing query values, and by observing that its only real responsibility beyond that is to know how to obtain the vtable for a particlar query from `tcx`.
…oli-obk Remove `rustc_feedable_queries` and `define_feedable` macros. The can be folded into `rustc_with_all_queries` and `define_callbacks`. Details in individual commits. r? @oli-obk
…donszelmann Port `#[register_tool]` to the new attribute system For rust-lang#131229 (comment) Rebase of rust-lang#146702 r? @jdonszelmann
…, r=jdonszelmann `unused_must_use` lint improvements The main purpose of this is to allow clippy to use `is_ty_must_use` from rustc, rather than making their own (outdated) copy. This also adds changes from rust-lang#148214 under a function flag, so clippy can start linting with the new semantics in mind, while rustc doesn't yet (see rust-lang#148214 (comment)). I've also done some refactoring while I was at it. r? @jdonszelmann
Update books ## rust-embedded/book 1 commits in fe88fbb68391a465680dd91109f0a151a1676f3e..99d0341ff4e06757490af8fceee790c4ede50bc0 2026-02-11 12:58:13 UTC to 2026-02-11 12:58:13 UTC - Remove triagebot.toml (rust-embedded/book#405) ## rust-lang/reference 21 commits in addd0602c819b6526b9cc97653b0fadca395528c..442cbef9105662887d5eae2882ca551f3726bf28 2026-02-22 02:55:12 UTC to 2026-02-11 01:41:05 UTC - Document importing path-segment keyword (rust-lang/reference#2136) - avoid needless dereference (rust-lang/reference#2180) - Use `clobber_abi`s corresponding to the called functions in `[asm.abi-clobbers.many]`'s example. (rust-lang/reference#2170) - expr.paren.evaluation: fix and make more simple (rust-lang/reference#2158) - const-eval.const-context.outer-generics: make more clear/obvious (rust-lang/reference#2159) - Nightly test links: update rust branch name (use `main`) (rust-lang/reference#2185) - tools/xtask: update rust branch name for linkcheck script (use `main`) (rust-lang/reference#2184) - specify `if let` guards with updated scoping rules (rust-lang/reference#1957) - Document assignment expression as coercion site (rust-lang/reference#1954) - Remove exception WRT same-crate `non_exhaustive` reads (rust-lang/reference#2162) - Add negative lookahead (rust-lang/reference#2172) - Switch to new range syntax (rust-lang/reference#2173) - add mdbook output for dev-guide to ignore file (rust-lang/reference#2178) - Fix rule name for while syntax (rust-lang/reference#2175) - block-expr: add new rule expr.block.result-value (rust-lang/reference#2174) - lifetime-elision.md: add some missing periods (rust-lang/reference#2176) - Add cut operator (`^`) to grammar (rust-lang/reference#2104) - dev-guide stabilization.md: add missing "not" (rust-lang/reference#2167) - Add method call and await expr for Dot in syntax index (rust-lang/reference#2163) - Fix sort of punctuation list (rust-lang/reference#2161) - Add a contributor guide (rust-lang/reference#2097) ## rust-lang/rust-by-example 1 commits in bac931ef1673af63fb60c3d691633034713cca20..5383db524711c0c9c43c3ca9e5e706089672ed6a 2026-02-16 12:02:33 UTC to 2026-02-16 12:02:33 UTC - 1.2.2 Display: Fix typo in bonus instructions (before -> after) (rust-lang/rust-by-example#1998)
…=JonathanBrouwer Fix attribute parser and kind names. For the attribute `FooBar` the parser is generally called `FooBarParser` and the kind is called `AttributeKind::FooBar`. This commit renames some cases that don't match that pattern. The most common cases: - Adding `Rustc` to the front of the parser name for a `rustc_*` attribute. - Adding `Parser` to the end of a parser name. - Slight word variations, e.g. `Deprecation` instead of `Deprecated`, `Pointer` instead of `Ptr`, `Stability` instead of `Stable`. r? @JonathanBrouwer
Clarify how "ensure" queries check whether they can skip execution The current `check_cache: bool` field in QueryMode is confusing for a few reasons: - It actually refers to checking the *disk cache*, not the in-memory cache. - It gives no indication of what condition is being checked, or why. - It obscures the link between `tcx.ensure_ok()` and `tcx.ensure_done()`, and the actual check. This PR replaces that field with an `EnsureMode` enum that distinguishes between ensure-ok and ensure-done, and leaves the actual check as an implementation detail of the ensure-done mode. This PR also renames `ensure_must_run` → `check_if_ensure_can_skip_execution`, and uses a return struct to more clearly indicate how this helper function gives permission for its caller to skip execution of a query that would otherwise be executed. This also inverts the sense of the returned boolean, which was previously “must run” but is now ”skip execution”. r? nnethercote (or compiler)
Member
Author
|
Trying commonly failed jobs |
rustbot
added
A-attributes
rustbot
added
O-SGX
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
Rollup of 9 pull requests try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #153032, which is a member of this rollup, was unapproved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
exitout of PAL #152657 (std: moveexitout of PAL)QueryVTableUnerasedintoGetQueryVTable#152841 (StreamlineQueryVTableUnerasedintoGetQueryVTable)rustc_feedable_queriesanddefine_feedablemacros. #153009 (Removerustc_feedable_queriesanddefine_feedablemacros.)#[register_tool]to the new attribute system #152988 (Port#[register_tool]to the new attribute system)unused_must_uselint improvements #153018 (unused_must_uselint improvements)r? @ghost
Create a similar rollup