Skip to content

library: motor: bump moto-rt ABI ver to 17 - #160392

Open
lasiotus wants to merge 1 commit into
rust-lang:mainfrom
moturus:motor-os-rt-v17
Open

library: motor: bump moto-rt ABI ver to 17#160392
lasiotus wants to merge 1 commit into
rust-lang:mainfrom
moturus:motor-os-rt-v17

Conversation

@lasiotus

@lasiotus lasiotus commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

View all comments

Newly added features:

  • vectored read/write
  • file locking
  • native paths (bin/tmp/home)
  • command output
  • process pid

@rustbot

rustbot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 2, 2026
@rustbot

rustbot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

r? @LawnGnome

rustbot has assigned @LawnGnome.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 8 candidates

@lasiotus

lasiotus commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

This PR fixes #160366

@lasiotus
lasiotus force-pushed the motor-os-rt-v17 branch 2 times, most recently from 44a90a0 to 026855b Compare August 6, 2026 22:43
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@lasiotus

Copy link
Copy Markdown
Contributor Author

@tgross35 Trevor, maybe you can look at this PR? It's been gathering dust for 2+ weeks...

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really doing r-l/r reviews as of late so might not be the best one to ping - you can always @rustbot reroll if 2-4 weeks go by without hearing back (though pinging the reviewer after a little bit never hurts).

That said, this was pretty tiny so I was able to do a pretty quick review, few minor requests. Could you also add a summary of what changed to the PR description? Looks like vectored reads/writes is the main thing.

View changes since this review

Comment thread library/std/src/process/tests.rs Outdated
Comment thread library/std/src/sys/process/motor.rs Outdated
Comment thread library/std/src/sys/process/motor.rs
Comment thread library/std/src/sys/paths/motor.rs
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2026
@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 20, 2026
@tgross35

Copy link
Copy Markdown
Member

r? me

@rustbot rustbot assigned tgross35 and unassigned LawnGnome Aug 20, 2026
@lasiotus

Copy link
Copy Markdown
Contributor Author

I'm not really doing r-l/r reviews as of late so might not be the best one to ping - you can always @rustbot reroll if 2-4 weeks go by without hearing back (though pinging the reviewer after a little bit never hurts).

That said, this was pretty tiny so I was able to do a pretty quick review, few minor requests. Could you also add a summary of what changed to the PR description? Looks like vectored reads/writes is the main thing.

Thanks a lot, Trevor! I will update the PR with the fixes you requested later today (will also update the PR description).

@rust-bors

This comment has been minimized.

@rustbot

rustbot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

…ing methods

Newly implemented/adjusted:
- vectored read/write
- file locking
- native paths (bin/tmp)
- command output
- process pid
@lasiotus

Copy link
Copy Markdown
Contributor Author

Could you also add a summary of what changed to the PR description? Looks like vectored reads/writes is the main thing.

Done.

@lasiotus

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants