Skip to content

Add back homu-ignore markers around the PR template - #160872

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
steffahn:put_back_homu-ignore
Aug 11, 2026
Merged

Add back homu-ignore markers around the PR template#160872
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
steffahn:put_back_homu-ignore

Conversation

@steffahn

@steffahn steffahn commented Aug 10, 2026

Copy link
Copy Markdown
Member

Besides reinstantiating the homu-ignore markers from #126501, this PR also adds better clarification how the homu-ignore markers actually work; I've then also moved that section further down as it seems less important than the other parts of the PR template message. (We shouldn't forget that this is a general PR template message, not a LLM-policy-specific message.)

The disclosure markers appear to have been accidentally removed together with the checkboxes in #160785.

In the future, if support for ignoring HTML comments in places such as markdown code blocks was added, the new description about how <!-- homu-ignore:end -->/<!-- homu-ignore:start --> can be used could be further simplified1, but I'd like to address the immediate issues first before considering any more involved improvements (there already exist [currently 6 8] new PRs now that contain the whole template comment without homu-ignore markers).

Footnotes

  1. actually it may always stay non-ideal given that HTML comments don't nest 🫠

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2026
@rustbot

rustbot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

Comment thread .github/pull_request_template.md Outdated
@steffahn
steffahn force-pushed the put_back_homu-ignore branch from 88dee8f to 775d38b Compare August 10, 2026 22:33
Also clarify how the homu-ignore markers actually work.
@steffahn
steffahn force-pushed the put_back_homu-ignore branch from 775d38b to 0bcefa1 Compare August 10, 2026 23:16
@steffahn

Copy link
Copy Markdown
Member Author

I've fixed the (8) affected open PRs manually for now.1 Will do that a second time once this is merged.

(I've also fixed a handful of older cases based on the previous version of the template, where authors had accidentally removed the homu-ignore:end together with the HTML comment, while keeping the boxes and homu-ignore:start.)

Footnotes

  1. Finding relevant PRs with gh api '/repos/rust-lang/rust/pulls?page=1' | jq 'map({ number, body })' + using the search functionality of my terminal

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bcefa1 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
@jieyouxu

Copy link
Copy Markdown
Member

@bors p=1 note="can be rolled up, just noisy in git commit history"

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
Rollup of 6 pull requests

Successful merges:

 - #160872 (Add back homu-ignore markers around the PR template)
 - #160432 (core: generalize `BorrowedCursor::ensure_init`)
 - #160843 (Overhaul `rustc_query_impl`)
 - #160865 (use `static` instead of `const` for derive(Debug))
 - #160866 (Update books)
 - #160881 (Implement <OnceCell,OnceLock>::new_init)
@rust-bors
rust-bors Bot merged commit 98ce159 into rust-lang:main Aug 11, 2026
13 checks passed
rust-timer added a commit that referenced this pull request Aug 11, 2026
Rollup merge of #160872 - steffahn:put_back_homu-ignore, r=jieyouxu

Add back homu-ignore markers around the PR template

Besides reinstantiating the `homu-ignore` markers from #126501, this PR also adds better clarification how the homu-ignore markers actually work; I've then also moved that section further down as it seems less important than the other parts of the PR template message. (We shouldn't forget that this is a *general PR template message*, not a LLM-policy-specific message.)

The disclosure markers appear to have been accidentally removed together with the checkboxes in #160785.

In the future, if support for ignoring HTML comments in places such as markdown code blocks was added, the new description about how `<!-- homu-ignore:end -->`/`<!-- homu-ignore:start -->` can be used could be further simplified[^1], but I'd like to address the immediate issues first before considering any more involved improvements (there already *exist* [currently ~~6~~ 8] new PRs now that contain the whole template comment without `homu-ignore` markers).

[^1]: actually it may always stay non-ideal given that HTML comments don't nest 🫠
@rustbot rustbot added this to the 1.99.0 milestone Aug 11, 2026
@steffahn

steffahn commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

I've manually fixed 2 more PRs' descriptions now so it's all handled, good to have gotten this merged so quickly ^^ - thanks @jieyouxu

(Another 5 new PRs were already opened since, at the time of this writing, that benefitted from this so far, as those now do contain the comments properly guarded again.)

@steffahn

steffahn commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

As for unfixed "broken" cases that got through: 6 cases1 of LLM checkboxes made it into git history, 4 of which contain unmatched homu-ignore:start markers (where the author had accidentally removed the homu-ignore:end together with the informative comment from the template, when the template still had the checkboxes).

No case of the Please read our [LLM policy] … comment has made it into commit messages.

Footnotes

  1. You can find those e.g. with git log --grep "\] I did not use an LLM" on an up to date checkout of the rust repo.

pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Aug 16, 2026
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#160872 (Add back homu-ignore markers around the PR template)
 - rust-lang/rust#160432 (core: generalize `BorrowedCursor::ensure_init`)
 - rust-lang/rust#160843 (Overhaul `rustc_query_impl`)
 - rust-lang/rust#160865 (use `static` instead of `const` for derive(Debug))
 - rust-lang/rust#160866 (Update books)
 - rust-lang/rust#160881 (Implement <OnceCell,OnceLock>::new_init)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants