Import suggestion noise: add a generic parameter filter - #161182
Draft
GTimothy wants to merge 3 commits into
Draft
Import suggestion noise: add a generic parameter filter#161182GTimothy wants to merge 3 commits into
GTimothy wants to merge 3 commits into
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
12 tasks
GTimothy
force-pushed
the
import-suggestion-generic-parameter-filter-heuristic
branch
from
August 16, 2026 17:01
5553da5 to
31792bf
Compare
Contributor
|
☔ The latest upstream changes (presumably #161505) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a heuristic to reduce suggestion noise: filter out suggestions that do not need generic parameters when some were provided in the code.
This was implemented when I realised that
Cloned<()>being out of scope was generating a suggestion to useClonewhich:This work was extracted from PR #156239.
@rustbot r? mu001999