Improve support for ARM benchmarks - #2550
Merged
Merged
Conversation
Before, the `Eq`/`Hash` implementations were ignoring some benchmark parameters.
Kobzol
force-pushed
the
arm
branch
2 times, most recently
from
August 29, 2026 12:36
472894e to
9f2d1ab
Compare
Kobzol
changed the title
The compare page will still include all targets.
lqd
reviewed
Aug 31, 2026
lqd
approved these changes
Aug 31, 2026
lqd
left a comment
lqd
left a comment
Member
There was a problem hiding this comment.
I haven't tested this locally, but reading it through made sense to me
Member
Author
|
Let's try on production! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now finally have an ARM machine for benchmarking, I tested having both x64 and ARM data locally, and found some issues, which this PR solves.
This PR:
It doesn't yet enable running ARM benchmarks by default, because we don't yet build aarch64 artifacts by default in try builds.