Implement SIMD funnel shift intrinsics - #1698
Open
Sonike wants to merge 1 commit into
Open
Conversation
Lower simd_funnel_shl and simd_funnel_shr lane by lane, including zero-shift and i128 handling. Re-enable the upstream generic arithmetic test.
Author
|
CI note: I attempted to rerun only the failed job, but GitHub requires repository admin permission for an upstream workflow rerun. A maintainer rerun should confirm whether the randomized LLVM-only test is flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simd_funnel_shlandsimd_funnel_shrlane by lane with Cranelift integer operationstests/ui/simd/intrinsic/generic-arithmetic-pass.rsin the rustc test suiteThe implementation follows the existing scalarized SIMD lowering strategy. Native vector instructions can be considered separately in the future.
Testing
cargo fmt --check./y.sh build./test.shgeneric-arithmetic-pass.rstest against this backendFixes #1696