Remove repeated --style-edition option - #7050
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
matthewhughes934
force-pushed
the
remove-repeated-option
branch
from
August 23, 2026 15:41
6ca0559 to
4c8f491
Compare
Due to a quirk of history, there were two version of this flag. The flag used to be nested under `is_nightly` but then separately: * f649c4c: move it to the main options, with `(unstable)` * 840eb96: moved it to the main options, without `(unstable)` Those two commits were part of subtree pushes, so the two commits were likely made at roughly the same time on different subtrees. There should be no functional change here, the flags were identical, so no distinction was ever made when matching on them with `matches.opt_str("style-edition")` Fixes: rust-lang#7046
matthewhughes934
force-pushed
the
remove-repeated-option
branch
from
August 23, 2026 15:53
4c8f491 to
72fa0cf
Compare
Member
The second commit was probably my fault 😆 I think I only changed the nightly gating but didn't notice the double-registration on rust-lang/rust side |
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a quirk of history, there were two version of this flag. The flag used to be nested under
is_nightlybut then separately:(unstable)(unstable)Those two commits were part of subtree pushes, so the two commits were likely made at roughly the same time on different subtrees.
There should be no functional change here, the flags were identical, so no distinction was ever made when matching on them with
matches.opt_str("style-edition")Fixes: #7046