Skip to content

Simpler way of deduplicating code in duplicate checks - #2702

Draft
steffahn wants to merge 2 commits into
rust-lang:mainfrom
steffahn:simple_code_deduplication
Draft

Simpler way of deduplicating code in duplicate checks#2702
steffahn wants to merge 2 commits into
rust-lang:mainfrom
steffahn:simple_code_deduplication

Conversation

@steffahn

Copy link
Copy Markdown
Member

Alternative to #2701

No LLMs were used in this PR 😃

@github-actions

Copy link
Copy Markdown
Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

@steffahn

steffahn commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

I touched the code some more, resulting in a larger refactor of the duplication checking function,
as well as adding detection for duplicate role assignment (which didn't exist previously, and uses the refactored duplicate detection), as well as validation for roles in alumni.

Since that's a complete rewrite of the PR, it's a new PR (→ #2703); I'm leaving this one as draft [as long as #2701 remains open] for illustrative purposes so my comments in #2701 (comment) still make sense.

@steffahn
steffahn marked this pull request as draft August 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant