Simpler way of deduplicating code in duplicate checks - #2702
Draft
steffahn wants to merge 2 commits into
Draft
Conversation
steffahn
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
August 21, 2026 12:51
steffahn
force-pushed
the
simple_code_deduplication
branch
from
August 21, 2026 12:52
061c184 to
bf3b182
Compare
Dry-run check results |
Member
Author
|
I touched the code some more, resulting in a larger refactor of the duplication checking function, Since that's a complete rewrite of the PR, it's a new PR (→ #2703); I'm leaving this one as draft [as long as #2701 remains open] for illustrative purposes so my comments in #2701 (comment) still make sense. |
steffahn
marked this pull request as draft
August 21, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2701
No LLMs were used in this PR 😃