Skip to content

refactor: improve console UI safety and consistency#160

Merged
overtrue merged 2 commits into
mainfrom
overtrue/ui-review-interaction-polish
Jul 11, 2026
Merged

refactor: improve console UI safety and consistency#160
overtrue merged 2 commits into
mainfrom
overtrue/ui-review-interaction-polish

Conversation

@overtrue

@overtrue overtrue commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Description

This PR applies the completed Console-wide UI and interaction review across status, settings, bucket configuration, SSE/KMS, IAM, dialogs, tables, responsive layouts, and navigation.

The work focuses on clearer hierarchy, safer state handling, fixed dialog actions, mobile parity, accessible controls, and eliminating unnecessary nested frames. The complete finding-to-resolution record is kept in docs/ui-review/register.md (UI-001 through UI-031).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Main changes

  • Reworked running status, server health, pool decommission, and rebalance states so loading, partial, stale, error, and empty data are distinct.
  • Standardized bucket settings and rule flows for lifecycle, replication, events, encryption, policy, quota, and retention.
  • Hardened SSE/KMS mutation safety, destructive confirmations, secret redaction, unsaved-change handling, mobile key actions, and Local KMS restrictions.
  • Improved IAM and access-key dialogs, selectors, focus restoration, table semantics, validation, and failure recovery.
  • Fixed long-form dialog scrolling, Policy editor containment, compact desktop controls, login form width, detail-page action placement, and top-navigation avatar spacing.
  • Preserved upstream object rename, lazy loading, version recovery, degraded health states, and updated translations while rebasing onto the latest main.
  • Added the reusable Console design guide under skills/rustfs-console-design-guide/ and the audit workflow record under docs/ui-review/.

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
node --test tests/lib/*.test.js
pnpm build
git diff --check

Result: 212 tests passed; production build passed. Next.js only emitted the existing multiple-lockfile workspace-root warning.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added

Related Issues

No linked issue.

Screenshots

Area Evidence keys
Running status and pool operations running-status-10, pool-operations-9
Bucket settings and rule flows bucket-settings-11, layout-followup-27
SSE/KMS sse-16-overview, sse-17-service-stop, sse-18-key-card-flow
IAM, dialogs, and remaining surfaces iam-13-a11y, remaining-21, avatar-inset-28

The committed source-of-truth mapping, issue descriptions, resolutions, and evidence status are in docs/ui-review/register.md. PNG comparisons remain outside the repository so temporary visual artifacts are not added to the product source tree.

Additional Notes

The branch was rebased onto the latest main before the final verification run.

@overtrue overtrue marked this pull request as ready for review July 11, 2026 02:54
Copilot AI review requested due to automatic review settings July 11, 2026 02:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overtrue overtrue merged commit 3a28a07 into main Jul 11, 2026
10 checks passed
@overtrue overtrue deleted the overtrue/ui-review-interaction-polish branch July 11, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants