Skip to content

refactor: harden task management and TypeScript safety#162

Merged
overtrue merged 2 commits into
mainfrom
overtrue/harden-task-manager-ts-safety
Jul 11, 2026
Merged

refactor: harden task management and TypeScript safety#162
overtrue merged 2 commits into
mainfrom
overtrue/harden-task-manager-ts-safety

Conversation

@overtrue

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Hardens the TypeScript codebase with a focused TaskManager redesign. Retry scheduling now respects concurrency and limits, task cleanup no longer cancels active work, handler types preserve task-kind relationships, and manager lifecycle cleanup is explicit.

Also fixes related upload/delete error handling, credential-change races, request logging safety, object preview/download guards, and several smaller type-safety issues found during the audit.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm prettier --check .
pnpm test:run
pnpm build

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

N/A

Screenshots (if applicable)

N/A

Additional Notes

The full test suite passes with 300 tests.

@overtrue overtrue marked this pull request as ready for review July 11, 2026 05:16
Copilot AI review requested due to automatic review settings July 11, 2026 05:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…manager-ts-safety

# Conflicts:
#	components/tasks/stats-button.tsx
@overtrue overtrue merged commit 85f5465 into main Jul 11, 2026
10 checks passed
@overtrue overtrue deleted the overtrue/harden-task-manager-ts-safety branch July 11, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants