refactor: harden task management and TypeScript safety#162
Merged
Conversation
…manager-ts-safety # Conflicts: # components/tasks/stats-button.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Hardens the TypeScript codebase with a focused TaskManager redesign. Retry scheduling now respects concurrency and limits, task cleanup no longer cancels active work, handler types preserve task-kind relationships, and manager lifecycle cleanup is explicit.
Also fixes related upload/delete error handling, credential-change races, request logging safety, object preview/download guards, and several smaller type-safety issues found during the audit.
Type of Change
Testing
pnpm install --frozen-lockfile pnpm type-check pnpm lint pnpm prettier --check . pnpm test:run pnpm buildChecklist
Related Issues
N/A
Screenshots (if applicable)
N/A
Additional Notes
The full test suite passes with 300 tests.