fix(sts): fail closed on policy binding errors#171
Merged
Conversation
Member
Author
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Fixes rustfs/backlog#1077
Summary of Changes
PolicyBindingcannot be fetched from RustFS.PolicyBindingpolicy document cannot be normalized for STS session-policy merging.PolicyBindingpolicy lists denied, while preserving specificInternalErrorandMalformedPolicyDocumentresponses for fetch and parse failures.AssumeRole.PolicyBindingpolicy must exist and resolve to a valid RustFS policy document.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](N/A: repository has noCHANGELOG.md)Impact
PolicyBindingpolicies are missing, unavailable, or malformed instead of issuing credentials from a partial policy set.Verification
cargo test -p operator --lib sts::server::tests:: -- --nocapture make pre-commitAdditional Notes
Live e2e tests remain ignored by default and were not run outside
make pre-commit.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.