Skip to content

Use ptr::NonNull for pointer checks - #698

Merged
ctz merged 1 commit into
mainfrom
jbp-null-checks
Oct 26, 2026
Merged

ctz merged 1 commit into
mainfrom
jbp-null-checks

Conversation

@ctz

@ctz ctz commented Oct 22, 2026

Copy link
Copy Markdown
Member

Use ? and let-else to improve code structure

(This PR is mostly mechanical and intended to be functionally neutral.)

@ctz
ctz force-pushed the jbp-null-checks branch from 65940d5 to 109c101 Compare October 22, 2026 16:23

@cpu cpu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much nicer ✨

Comment thread librustls/src/certificate.rs Outdated
Use ? and let-else to improve code structure
@ctz
ctz force-pushed the jbp-null-checks branch from 109c101 to 83ccd1b Compare October 26, 2026 09:12
@ctz
ctz enabled auto-merge (rebase) October 26, 2026 09:12
Comment thread librustls/src/certificate.rs
Comment thread librustls/src/ffi.rs
@djc
djc disabled auto-merge October 26, 2026 09:27
@djc

djc commented Oct 26, 2026

Copy link
Copy Markdown
Member

(Disabled the auto-merge for now, feel free to click the button again if you want to ignore my feedback.)

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ctz
ctz merged commit f55d964 into main Oct 26, 2026
64 checks passed
@ctz
ctz deleted the jbp-null-checks branch October 26, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants