Repository navigation
Add advisory for pulldown-cmark: Exponential event growth with ENABLE_WIKILINKS - #3454
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
Links to upstream issue(s) or PR(s)
ENABLE_WIKILINKS(#1102) and two panics (#1111, #1129) pulldown-cmark/pulldown-cmark#1179Severity
Remote denial-of-service via memory exhaustion. With
Options::ENABLE_WIKILINKSset (off by default, included inOptions::all()), each wikilink with a pipe and empty display text, such as[[a|]], roughly doubles the events yielded for the rest of the document: 112 bytes yield 327,676 events (65 when fixed), and a few kilobytes exhaust memory in a process that collects or renders the events. Affects 0.13.0 through 0.13.4; wikilinks were introduced in 0.13.0, and 0.13.5 is patched.CVSS 3.1 is 7.5, scored for a service that renders untrusted Markdown with wikilinks enabled.
AC:H, to account for the option being off by default, would give 5.9.Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure dateENABLE_WIKILINKS(#1102) and two panics (#1111, #1129) pulldown-cmark/pulldown-cmark#1179 and approved by the maintainer