Skip to content

i18n(ru): pluralize skipped rows and chart series - #2669

Merged
ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/russian-import-series-counts-573
Oct 3, 2026
Merged

ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/russian-import-series-counts-573

Conversation

@kavemang

@kavemang kavemang commented Oct 3, 2026 •

Copy link
Copy Markdown

What this PR does

Russian import summaries and Compare chart labels currently use the many form at every count, for example 2 строк пропущено and 2 рядов. Add CLDR one/few/many/other forms to the skipped-row and chart-series entries.

The skipped-row label is shared by nutrition CSV and Lab Book imports. Its English singular branch only receives 1, but Russian still needs one in the plural key for counts such as 21. All count placeholders and all other catalog keys/locales are preserved; neither key is duplicated in another shipped catalog.

Only two Russian translations change. No import parsing/filtering, stored data, chart calculation, layout or Android resource change. Remaining #573 counts are outside this small batch.

Draft for native Russian review requested by the issue and manual import/Compare label checks with 0, 1, 2, 5, 11, 21, 22 and 25.

Type of change

  • Bug fix

How it was tested

  • Focused JSON comparison verifies two ru entries only and single %lld arguments preserved.
  • Diff-scoped i18n against origin/main, global comment hygiene and whitespace passed.
  • Full local Tools discovery: 338 tests passed, zero failures, 185.115 seconds.
  • Apple CI: universal macOS and iOS Simulator SDK builds/String Catalog compilation succeeded. StrandTests ran 2,269 tests, two skipped, zero failures.
  • Tools CI: 50 parity acceptance, 2 R-R contract, 153 core Tools and 234 linux-capture tests passed.
  • Android CI: APK build succeeded; unit-test task FROM-CACHE, no fresh Android execution claimed. Android unchanged.
  • Stable exact-head roster: six checks, all successful, including i18n and hygiene.
  • Linux cannot build Apple targets; actual upstream SDK builds provide compile coverage. No native approval, runtime display/VoiceOver or hardware validation claimed.

Checklist

  • Existing UI/design tokens only; catalog-only edit
  • No new dependency, frame bytes, generated artifacts or secrets
  • Follows docs/CONTRIBUTING.md

Related issues

Refs #573

@kavemang
kavemang marked this pull request as ready for review October 3, 2026 20:31
@ryanbr
ryanbr merged commit ae201ed into ryanbr:main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants