[BUG] Service login prompt shows incorrect elevate command missing elevation reason flag

[samanthajayasinghe]

Description

When running ocm-backplane login $cluster --service, the printed elevate command for listing manifestworks is incorrect.

Issues found:

Missing the -n flag (which prompts the user for an elevation reason)

Used ocm backplane instead of the shipped binary name ocm-backplane

Current incorrect output:

ocm backplane elevate -- oc get manifestworks -n <ns> -l api.openshift.com/id=<id>

Expected correct output:

ocm-backplane elevate -n -- oc get manifestworks -n <ns> -l api.openshift.com/id=<id>

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 9:12 PM UTC · Completed 9:15 PM UTC
Commit: ae64d7c · View workflow run →

[fullsend-ai-triage]

Triage Summary

Confirmed bug in cmd/ocm-backplane/login/login.go at line 291.

The format string that generates the elevate command hint during --service login has two errors:

1. Wrong binary name: Uses ocm backplane instead of ocm-backplane
2. Missing -n flag: The -n (shorthand for --no-reason) flag is needed so the elevate command prompts the user for an elevation reason

Current output

ocm backplane elevate -- oc get manifestworks -n <ns> -l api.openshift.com/id=<id>

Expected output

ocm-backplane elevate -n -- oc get manifestworks -n <ns> -l api.openshift.com/id=<id>

Recommended Fix

Change the format string on line 291 of cmd/ocm-backplane/login/login.go:

// Before
listManifestWork := fmt.Sprintf("ocm backplane elevate -- oc get manifestworks -n %s -l api.openshift.com/id=%s", managingClusterName, targetClusterID)

// After
listManifestWork := fmt.Sprintf("ocm-backplane elevate -n -- oc get manifestworks -n %s -l api.openshift.com/id=%s", managingClusterName, targetClusterID)

Consider using os.Args[0] or a constant for the binary name to prevent future drift.

Proposed Test

// Test that the printed elevate command uses the correct binary name and includes -n flag
// In a test for the service login path on hosted control plane clusters:
// 1. Capture stdout during the service login flow
// 2. Assert the output contains "ocm-backplane elevate -n --"
// 3. Assert it does NOT contain "ocm backplane elevate --" (without hyphen, without -n)

[fullsend-ai-coder]

🤖 Code · ⚠️ Cancelled · Started 9:16 PM UTC · Ended 9:21 PM UTC
Commit: ae64d7c · View workflow run →

[samanthajayasinghe]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 9:22 PM UTC · Completed 9:36 PM UTC
Commit: ae64d7c · View workflow run →