Conversation
|
Important Review skippedToo many files! This PR contains 1011 files, which is 711 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (65)
📒 Files selected for processing (1011)
You can disable this status message by setting the Comment |
samcday
added this pull request to stack #212
September 20, 2026 07:05
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1
to
+8
| [submodule "gir"] | ||
| path = gir | ||
| url = https://github.com/gtk-rs/gir.git | ||
| update = none | ||
| [submodule "gir-files"] | ||
| path = gir-files | ||
| url = https://github.com/gtk-rs/gir-files.git | ||
| update = none |
There was a problem hiding this comment.
The imported gir and gir-files entries are gitlinks, but these mappings are placed in libphosh-rs/.gitmodules while the repository-level .gitmodules is empty. Git therefore cannot resolve either mapping in a fresh checkout, and the binding regeneration command in libphosh-rs/Makefile fails when it tries to initialize gir. Register both gitlinks in the root .gitmodules using their full repository-relative paths.
| @@ -0,0 +1,27 @@ | |||
| use glib; | |||
There was a problem hiding this comment.
This example and custom-shell-and-lockscreen.rs use hyphenated filenames. The repository guide requires filenames to use snake_case, so these examples must be renamed with underscores before merging.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
samcday
marked this pull request as ready for review
September 20, 2026 09:26
git-subtree-dir: phosh git-subtree-split: 62fde093044d90b82154e68a39feb8e6ea967ef5
git-subtree-dir: libphosh-rs git-subtree-split: 5a356759a8f087263c0656d6a11dce2e76cab551
samcday
force-pushed
the
vendor-base
branch
from
September 20, 2026 23:23
bce0d8f to
f62d3a3
Compare
samcday
removed this pull request from stack #212
September 21, 2026 06:37
samcday
added this pull request to stack #214
September 21, 2026 06:37
This was referenced Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import the pristine GTK3 Phosh and libphosh-rs source snapshots as the foundation for #186. Keeping these imports in the bottom layer lets reviewers inspect the embedding changes separately.
Phosh:
62fde093044d90b82154e68a39feb8e6ea967ef5(0.53.0). Rust bindings:5a356759a8f087263c0656d6a11dce2e76cab551.No build selection, integration patches, or packaging defaults change in this layer. Ordinary builds still use system libphosh.
Subtrees now use real
git subtree --squashimports/updates, with downstream changes in separate commits. Source contents are unchanged by the history rewrite;AGENTS.mdrecords the verified update and patch-export workflow. Land this stack with merge commits, preserving the subtree metadata and parent commits; do not use GitHub squash/rebase merging.