Repository navigation
fix(sema): keep break generation advances within their loop - #1418
Merged
Merged
Conversation
sanohiro
marked this pull request as ready for review
October 25, 2026 05:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested loops could reject a still-live outer array as expired. A break edge collected generation advances from frames preceding its loop, so later joins could age the outer Current into an ended Prior generation. Stop collecting at the existing innermost Loop marker, in both statement and value-bearing break walkers; completed inner advances still propagate to the parent normally.
The language, finite generation model, runtime and cleanup stay unchanged. Plan245 records the invariant and closure matrix.
Validation: parameterized whole/per-unit loop depth and owner placement, branch/else/Try/map_err/return/value-break composition, actual replacement/temporary expiry negatives, imported generic native execution and cold/hit replay; direct frame invariant and existing borrow/loop/temporary/owned-composition owners. The authenticated MTP comparison and original failing source pass both frontends. Fresh independent full-diff review, final preflight, bounded gate and Clippy passed.