Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
A continued Assistant owns a new dormant Studio session. Its Terminal needs an explicit first-start action and a truthful state before any coding agent process has run.
Summary and scope
Add a distinct dormant Terminal pane and same-session Start Terminal request. Preserve current authority, navigation, foreground intent, End generations and newer bus state when adopting the response. Keep failed starts retryable and display immediate process exit truthfully. Continue acknowledgements also recheck the source's project/user/harness binding.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1031. Native stack target: main.
Validation
65 browser cases passed: 34 Continue/Start, 17 history/Resume, 6 End and 8 legacy Terminal transcript cases. Frontend TypeScript, explicit browser ESLint, formatting and diff checks passed. Removing either the End generation guard or source-authority check failed its targeted regression, then source was restored.
Before/after action screenshots and a short Continue → paused Assistant → explicit Start Terminal fixture video were captured and inspected. These controlled browser fixtures do not run a real PTY; combined native/browser and packaged checks are tracked separately.
Tests and documentation
Adds 19 browser cases for explicit activation, failed/repeated starts, immediate exit, identity substitutions, lost/late responses and bus ordering. Updated assistant-history.md. Increment: 508 changed lines including tests/docs/changeset; SDK pr:size is absent.
Compatibility and release impact
Security
AI assistance
Checklist
Review evidence
These images show disposable browser fixture states before and after an explicit user action, not a historical pre-implementation baseline. They do not establish native execution or an installed activated release.
Continue → paused Assistant → explicit Start Terminal → same paused Assistant (video). The Terminal fixture launches no PTY, so its surface is blank.