Skip to content

feat(harness): start continued session terminals explicitly [SAP-3292] - #1032

Closed
ynadge wants to merge 1 commit into
assistant-storage-cleanupfrom
assistant-terminal-start-controls
Closed

ynadge wants to merge 1 commit into
assistant-storage-cleanupfrom
assistant-terminal-start-controls

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Feature

Problem and motivation

A continued Assistant owns a new dormant Studio session. Its Terminal needs an explicit first-start action and a truthful state before any coding agent process has run.

Summary and scope

Add a distinct dormant Terminal pane and same-session Start Terminal request. Preserve current authority, navigation, foreground intent, End generations and newer bus state when adopting the response. Keep failed starts retryable and display immediate process exit truthfully. Continue acknowledgements also recheck the source's project/user/harness binding.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1031. Native stack target: main.

Validation

65 browser cases passed: 34 Continue/Start, 17 history/Resume, 6 End and 8 legacy Terminal transcript cases. Frontend TypeScript, explicit browser ESLint, formatting and diff checks passed. Removing either the End generation guard or source-authority check failed its targeted regression, then source was restored.

Before/after action screenshots and a short Continue → paused Assistant → explicit Start Terminal fixture video were captured and inspected. These controlled browser fixtures do not run a real PTY; combined native/browser and packaged checks are tracked separately.

Tests and documentation

Adds 19 browser cases for explicit activation, failed/repeated starts, immediate exit, identity substitutions, lost/late responses and bus ordering. Updated assistant-history.md. Increment: 508 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • Existing ordinary Terminal Resume is unchanged. Start uses the current boot-authenticated endpoint with no prompt/bootstrap/launch overrides.
  • Changeset: @sapiom/harness patch.
  • Fix-forward: correct the Start request/adoption path in a focused follow-up while preserving dormant state and explicit launch.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

Review evidence

These images show disposable browser fixture states before and after an explicit user action, not a historical pre-implementation baseline. They do not establish native execution or an installed activated release.

Before action After action
Before action After action

Continue → paused Assistant → explicit Start Terminal → same paused Assistant (video). The Terminal fixture launches no PTY, so its surface is blank.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3b9fa667-8ae0-453c-b80c-45e0c35c60ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant