Skip to content

fix(harness): reconcile exact continuation seed records [SAP-3292] - #1034

Closed
ynadge wants to merge 1 commit into
assistant-pending-child-visibilityfrom
assistant-seed-reconciliation
Closed

ynadge wants to merge 1 commit into
assistant-pending-child-visibilityfrom
assistant-seed-reconciliation

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Bug fix

Problem and motivation

Reconciling a fresh native snapshot could reintroduce a previously captured continuation seed and preserve inflated task counts after exact attestation excluded it.

Summary and scope

Remove only the provably excluded empty seed turn during reconciliation. Permit a seed-only record to become empty only with a locked proof of the exact prior revision and message, preserving concurrent newer records and real public work.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1033. Native stack target: main.

Validation

pnpm --filter @sapiom/harness test — 4,814 unit tests and 10 performance tests passed (2 skipped), including this review correction.

The combined focused core review run passed 304 tests. Server TypeScript, scoped ESLint and diff checks passed.

Tests and documentation

Seed/count regressions cover compacted work, real replies, changed/missing attestation and stale exclusion proof. Both capture and locked-revision mutations failed their regressions. Updated assistant-history.md. Increment: 241 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • No wire or persisted format migration; existing lifecycle and history contracts remain.
  • Changeset: @sapiom/harness patch.
  • Fix-forward: correct the exact seed proof or reconciliation in a focused follow-up; retain unrelated recorded history.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 40e7334a-3cda-4802-b057-0baa97cc3a1e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ynadge ynadge closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant