Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
A delayed End response could dismiss a Terminal that had already resumed. An Assistant Resume that committed over the event bus but lost its HTTP acknowledgement could discard the original request and leave the user unable to reconcile it.
Summary and scope
Fence ordinary Terminal Resume and End acknowledgements by their shared per-Studio operation generation and current authority. Keep an uncertain Assistant Resume's original inspected entry and operation UUID across its own lifecycle event and Close/Back; Retry Resume reconciles that exact request. Only a strictly parsed lifecycle conflict offers a fresh availability check.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1036. Native stack target: main.
Validation
Browser fixtures: 72/72 cases across assistant-continuation.spec.ts, assistant-end.spec.ts, assistant-history.spec.ts and past-session-record.spec.ts passed. Two deliberate guard regressions were detected, restored, and followed by the clean broader run. Frontend TypeScript, explicit browser ESLint (zero errors; one existing unused-type warning), scoped formatting and git diff --check passed. These fixtures do not establish native execution; assembled browser/native validation follows in the final stack.
Tests and documentation
Added delayed End/Terminal Resume ordering and uncertain Resume bus-commit/Close/Back regressions. Updated assistant-history.md. Increment: 338 changed lines including tests/docs/changeset; SDK pr:size is absent.
Compatibility and release impact
Security
AI assistance
Checklist
Review evidence
Disposable fixture states around explicit Resume: the initial verified action is from the earlier Resume fixture; the retry view is from the lost-acknowledgement regression. These are action states, not a historical baseline or native execution evidence.