Skip to content

fix(harness): preserve visibility and exact End admission [SAP-3292] - #1039

Closed
ynadge wants to merge 1 commit into
assistant-continue-conflict-recoveryfrom
assistant-visibility-reconciliation
Closed

ynadge wants to merge 1 commit into
assistant-continue-conflict-recoveryfrom
assistant-visibility-reconciliation

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Bug fix

Problem and motivation

Private pending continuation children could reach macros/Canvas outside the session-path router. Visibility reads could also block ordinary Terminal End during storage failure or publish an older hidden state after preparation completed.

Summary and scope

Apply the visibility boundary to macro, Canvas and Terminal connection entry points. Publish completed visibility reads in order on the existing Assistant revision clock. Preserve exact boot-authorized End independently of visibility IO while retaining positive pending-child privacy.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1038. Native stack target: main.

Validation

Root rerun: 185/185 tests across assembled server wiring, REST, Assistant state projection, Terminal WS, Canvas, Canvas render and macros passed. Server TypeScript and scoped ESLint passed. Seven deliberate in-memory regressions failed as expected; the final completed-publication race passed. Documentation/changeset formatting and git diff --check passed.

Tests and documentation

Added selected actual-PTY cleanup, before/after restart privacy, body/path action, WebSocket authorization, stale-read and visibility-only event regressions. Updated assistant-history.md. Increment: 472 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • Prepared Continue retry semantics and accepted-source ownership remain unchanged. No new runtime startup or disk IO is added to Terminal WebSocket admission. Execution still fails closed when the index is unavailable; exact authorized cleanup remains available. No native pin or activation change.
  • Changeset: @sapiom/harness patch.
  • Fix-forward: Keep execution gated and correct cache publication or the explicit cleanup exception while retaining the selected session for truthful retry.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 41adb328-974f-48b9-abb1-f26376fa5a94

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant