Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
Private pending continuation children could reach macros/Canvas outside the session-path router. Visibility reads could also block ordinary Terminal End during storage failure or publish an older hidden state after preparation completed.
Summary and scope
Apply the visibility boundary to macro, Canvas and Terminal connection entry points. Publish completed visibility reads in order on the existing Assistant revision clock. Preserve exact boot-authorized End independently of visibility IO while retaining positive pending-child privacy.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1038. Native stack target: main.
Validation
Root rerun: 185/185 tests across assembled server wiring, REST, Assistant state projection, Terminal WS, Canvas, Canvas render and macros passed. Server TypeScript and scoped ESLint passed. Seven deliberate in-memory regressions failed as expected; the final completed-publication race passed. Documentation/changeset formatting and git diff --check passed.
Tests and documentation
Added selected actual-PTY cleanup, before/after restart privacy, body/path action, WebSocket authorization, stale-read and visibility-only event regressions. Updated assistant-history.md. Increment: 472 changed lines including tests/docs/changeset; SDK pr:size is absent.
Compatibility and release impact
Security
AI assistance
Checklist