Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
Source tests could pass while a packaged desktop omitted Assistant lifecycle routes or lost retained state after End. The desktop smoke test now verifies those contracts through the packaged shared server.
Summary and scope
After creating a real Terminal, check that inspect/Resume/Continue reject malformed requests and missing boot tokens. End the session twice, verify its retained exited row and paused ended lifecycle, and reject ordinary Assistant attachment afterward. The test uses no Assistant grant or model provider.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1041. Native stack target: main.
Validation
The smoke launched the actual unsigned Linux unpacked app with isolated user state and app.asar packaging. Its existing two-native-runtime, real PTY, runtime shim, preload, bridge and map checks also passed. The fresh desktop suite passed 206 unit tests plus 7 signing-boundary checks before packaging. No artifact was published.
Tests and documentation
Extended the existing packaged session-create smoke; documented the scope in the desktop README. Increment: 30 changed lines.
pnpm pr:sizeis absent in this SDK; measured the incremental Git diff.Compatibility and release impact
Security
AI assistance
Checklist