Skip to content

test(desktop): verify packaged Assistant lifecycle contracts [SAP-3292] - #1042

Closed
ynadge wants to merge 1 commit into
terminal-start-acknowledgmentfrom
packaged-assistant-lifecycle
Closed

ynadge wants to merge 1 commit into
terminal-start-acknowledgmentfrom
packaged-assistant-lifecycle

Conversation

@ynadge

@ynadge ynadge commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Tests

Problem and motivation

Source tests could pass while a packaged desktop omitted Assistant lifecycle routes or lost retained state after End. The desktop smoke test now verifies those contracts through the packaged shared server.

Summary and scope

After creating a real Terminal, check that inspect/Resume/Continue reject malformed requests and missing boot tokens. End the session twice, verify its retained exited row and paused ended lifecycle, and reject ordinary Assistant attachment afterward. The test uses no Assistant grant or model provider.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1041. Native stack target: main.

Validation

env -u VITE_MOCK pnpm build — passed
node packages/harness-desktop/scripts/pack.mjs --linux --dir — passed
env -u CI packages/harness-desktop/scripts/smoke.sh — 17 passed, 1 Windows-only agent-shim skip

The smoke launched the actual unsigned Linux unpacked app with isolated user state and app.asar packaging. Its existing two-native-runtime, real PTY, runtime shim, preload, bridge and map checks also passed. The fresh desktop suite passed 206 unit tests plus 7 signing-boundary checks before packaging. No artifact was published.

Tests and documentation

Extended the existing packaged session-create smoke; documented the scope in the desktop README. Increment: 30 changed lines. pnpm pr:size is absent in this SDK; measured the incremental Git diff.

Compatibility and release impact

  • Test-only change; production activation and native pin unchanged. Linux default-path smoke does not establish signed installed E3 acceptance.
  • Changeset: N/A; private desktop package smoke coverage and documentation only.
  • Fix-forward: Correct the packaged lifecycle wiring or retained-state regression exposed by these checks before continuing release delivery.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change and ran the packaged verification above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 006e83dc-664f-462f-b340-2ae83cca20cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant