Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
Integrators need a typed return destination when opening Sapiom's hosted purchase approval and card-confirmation flow from another app.
Summary and scope
Add optional
returnUrlfields to the existing transaction create/response types, with integration guidance, release notes and a minor Changeset. The existing client already forwards the request body; destination validation, persistence and hosted navigation are implemented by the companion backend.Related work
Requested follow-up to SAP-4059. Backend/UI: https://github.com/sapiom/Sapiom/pull/5938.
Validation
Tests and documentation
Core's existing tests pass. No runtime code changes or new transport logic; the backend companion tests the approval/CVV return behavior. README and CHANGELOG document registration, per-purchase context and payment-status semantics. Root workspace checks were scoped to the affected core package.
Compatibility and release impact
purchase-return-url.md(@sapiom/core, minor).Security
AI assistance
Codex added the optional fields and documentation and verified the package build, type check, tests and formatting.
Checklist
CONTRIBUTING.md; this implements the maintainer-requested return navigation contract.