Repository navigation
Ability to compile without GNU Scientific Library - #36
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The tennis model reverses the stated top-spin effect, references a missing image, and introduces substantial unrelated scope.
13 open findings
What changed in this PR
Makes GSL optional while preserving clear runtime errors for GSL-only functions. It also includes unrelated example and documentation updates.
Changes:
- Adds conditional GSL detection, runtime errors, and regression coverage.
- Adds a tennis-ball DAE example and generated documentation.
- Refreshes installation, mechanical-example, changelog, and document metadata.
| File | Description |
|---|---|
tests/special-functions-gsl.sh |
Tests GSL-dependent built-ins. |
src/math/builtin_functions.c |
Handles unavailable GSL functions. |
README.md |
Updates installation command. |
README.markdown |
Mirrors installation update. |
README |
Mirrors installation update. |
Makefile.am |
Registers conditional GSL test. |
examples/tennis.yaml |
Defines tennis example metadata. |
examples/tennis.gp |
Plots tennis trajectories. |
examples/tennis.fee |
Implements tennis DAE model. |
examples/README.markdown |
Links the tennis example. |
examples/mechanical.md |
Refreshes mechanical documentation. |
examples/mechanical.markdown |
Mirrors mechanical documentation. |
examples/make.sh |
Adds tennis page generation. |
examples/examples.md |
Links the tennis example. |
examples/daes.md |
Adds generated tennis documentation. |
examples/daes.markdown |
Adds alternate generated documentation. |
examples/.gitignore |
Ignores tennis outputs. |
doc/feenox.1 |
Updates manual date. |
doc/FAQ.markdown |
Updates document date. |
doc/CODE_OF_CONDUCT.markdown |
Updates document date. |
configure.ac |
Exposes GSL availability to Automake. |
ChangeLog.md |
Records optional-GSL support and typo fix. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+1320
to
+1321
| <img src="tennis-top.svg" | ||
| alt="Effect of top spin in the trajectory of a tennis ball" /> |
| ``` | ||
|
|
||
|
|
||
|  |
| @@ -0,0 +1,68 @@ | |||
| PHASE_SPACE x vx y vy theta omega Fy Fx tau | |||
Corrected the signs of the Magnus force equations for Fx and Fy. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Corrected the signs for the Magnus force calculations. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.