Repository navigation
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
seafile-dev
approved these changes
Sep 23, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Approve
已复核现有阻塞意见： 对整数参数使用 格式化，命令行参数会被正确转换为字符串；当前实现可以按 24 小时间隔调用清理命令。未发现新的阻塞问题。
seafile-dev
reviewed
Sep 23, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
复核结论：run() 使用 "%s" % arg 格式化整数参数时会得到字符串，清理命令参数可被 Django 的 int 解析；此前的阻塞判断不成立。当前实现未发现新的阻塞问题。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.